linux-kernel - Re: [PATCH v2] mfd: mc13xxx-core: Initialize the lock prior to using it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140416091531.GD4754@lee--X1>
Date:	Wed, 16 Apr 2014 10:15:31 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Fabio Estevam <festevam@...il.com>
Cc:	sameo@...ux.intel.com, linux@....linux.org.uk,
	linux-kernel@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH v2] mfd: mc13xxx-core: Initialize the lock prior to using
 it

> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> After request_threaded_irq() is called there is a chance that an interrupt
> may occur before the 'mc13xxx->lock' is initialized, which will trigger a kernel
> oops.
> 
> In order to prevent that, move the initialization of 'mc13xxx->lock' prior to
> requesting the interrupts.
> 
> Suggested-by: Russell King <rmk+kernel@....linux.org.uk>
> Signed-off-by: Fabio Estevam <fabio.estevam@...escale.com>
> ---
> Changes since v1:
> - Changed kernel warning --> kernel oops to better describe the problem
> - Added Russell's Ack

No you didn't. ;)

Applied with Russell's Ack.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/