[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140416094034.GA18082@devel>
Date: Wed, 16 Apr 2014 18:40:40 +0900
From: Daeseok Youn <daeseok.youn@...il.com>
To: plagnioj@...osoft.com
Cc: tomi.valkeinen@...com, jg1.han@...sung.com,
laurent.pinchart@...asonboard.com, daeseok.youn@...il.com,
robdclark@...il.com, linux-fbdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH] fbdev: fix possible NULL pointer derefernce
The spec->modedb can be NULL by fb_create_modedb().
And also smatch says:
drivers/video/fbdev/core/fbmon.c:975 fb_edid_to_monspecs() error:
potential null dereference 'specs->modedb'.
(fb_create_modedb returns null)
Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
---
drivers/video/fbdev/core/fbmon.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/video/fbdev/core/fbmon.c b/drivers/video/fbdev/core/fbmon.c
index c204ebe..db274ca 100644
--- a/drivers/video/fbdev/core/fbmon.c
+++ b/drivers/video/fbdev/core/fbmon.c
@@ -966,6 +966,9 @@ void fb_edid_to_monspecs(unsigned char *edid, struct fb_monspecs *specs)
specs->modedb = fb_create_modedb(edid, &specs->modedb_len);
+ if (!specs->modedb)
+ return;
+
/*
* Workaround for buggy EDIDs that sets that the first
* detailed timing is preferred but has not detailed
--
1.7.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists