| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <534E778F.5090007@mev.co.uk> Date: Wed, 16 Apr 2014 13:29:03 +0100 From: Ian Abbott <abbotti@....co.uk> To: Chase Southwood <chase.southwood@...oo.com>, <gregkh@...uxfoundation.org> CC: <hsweeten@...ionengravers.com>, <devel@...verdev.osuosl.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 2/2 v2] staging: comedi: addi_apci_1564: fixup and absorb apci1564_reset() On 2014-04-16 07:57, Chase Southwood wrote: > We can remove this function from the boardinfo and move the code from > hwdrv_apci1564.c into addi_apci_1564.c since it is the only reset function > used by the driver. The function was also messy and failed to reset a few > registers, these issues were fixed on the move. > > Signed-off-by: Chase Southwood <chase.southwood@...oo.com> > --- > 2: *Changed order of register accesses for digital input registers back to > original ordering. > *Removed read of digital output status register and reordered the accesses > of digital output registers to agree with the order found in addi_apci_2032. > *Fixed copy/paste error in the counter register reset lines. > > Ian, I addressed your comments as above. > Chase Looks good. Reviewed-by: Ian Abbott <abbotti@....co.uk> -- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@....co.uk> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists