linux-kernel - Re: [PATCH v2 linux-next] ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5h38hdfj88.wl%tiwai@suse.de>
Date:	Wed, 16 Apr 2014 16:21:27 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Tim Gardner <tim.gardner@...onical.com>
Cc:	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Jaroslav Kysela <perex@...ex.cz>,
	Mark Brown <broonie@...aro.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	JongHo Kim <furmuwon@...il.com>
Subject: Re: [PATCH v2 linux-next] ALSA: pcm: 'BUG:' message unnecessarily triggers kerneloops

At Wed, 16 Apr 2014 08:18:35 -0600,
Tim Gardner wrote:
> 
> BugLink: http://bugs.launchpad.net/bugs/1305480
> 
> The kerneloops-daemon scans dmesg for common crash signatures, among
> which is 'BUG:'. The message emitted by the PCM library is really a
> warning, so the most expedient thing to do seems to be to change the
> string.
> 
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.de>
> Cc: Mark Brown <broonie@...aro.org>
> Cc: Lars-Peter Clausen <lars@...afoo.de>
> Cc: JongHo Kim <furmuwon@...il.com>
> Signed-off-by: Tim Gardner <tim.gardner@...onical.com>

Thanks, applied.


Takashi

> ---
> 
> v2: Changed string preface from "OVER RUN" to "XRUN". As Takashi pointed out,
> 'Use a term "XRUN", as it's not always an overrun.'
> 
>  sound/core/pcm_lib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c
> index ce83def..9acc77e 100644
> --- a/sound/core/pcm_lib.c
> +++ b/sound/core/pcm_lib.c
> @@ -345,7 +345,7 @@ static int snd_pcm_update_hw_ptr0(struct snd_pcm_substream *substream,
>  			snd_pcm_debug_name(substream, name, sizeof(name));
>  			xrun_log_show(substream);
>  			pcm_err(substream->pcm,
> -				"BUG: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
> +				"XRUN: %s, pos = %ld, buffer size = %ld, period size = %ld\n",
>  				name, pos, runtime->buffer_size,
>  				runtime->period_size);
>  		}
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/