linux-kernel - Re: [PATCH V4 5/5] usb-phy: samsung-usb3: Remove older phy-samsung-usb3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFp+6iEyyfQprhNO5wt_f53QcXCriL_rvTtJBxsFZ0BON=fiFA@mail.gmail.com>
Date:	Wed, 16 Apr 2014 20:12:39 +0530
From:	Vivek Gautam <gautam.vivek@...sung.com>
To:	Richard Genoud <richard.genoud@...il.com>
Cc:	Tomasz Figa <t.figa@...sung.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Kamil Debski <k.debski@...sung.com>,
	"linux-samsung-soc@...r.kernel.org" 
	<linux-samsung-soc@...r.kernel.org>, linux-doc@...r.kernel.org,
	Greg KH <gregkh@...uxfoundation.org>,
	Linux USB Mailing List <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Felipe Balbi <balbi@...com>, kishon <kishon@...com>,
	Kukjin Kim <kgene.kim@...sung.com>,
	Jingoo Han <jg1.han@...sung.com>,
	Sylwester Nawrocki <sylvester.nawrocki@...il.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V4 5/5] usb-phy: samsung-usb3: Remove older
 phy-samsung-usb3 driver

Hi Richard,


On Wed, Apr 16, 2014 at 7:03 PM, Richard Genoud
<richard.genoud@...il.com> wrote:
> Hi Vivek,
>
> 2014-04-09 13:34 GMT+02:00 Vivek Gautam <gautam.vivek@...sung.com>:
>> Hi Tomasz,
>> '
>>
>> On Wed, Apr 9, 2014 at 4:43 PM, Tomasz Figa <t.figa@...sung.com> wrote:
>>> Hi Vivek,
>>>
>> Thanks for reviewing the patch series.
>>
>>>
>>> On 08.04.2014 16:36, Vivek Gautam wrote:
>>>>
>>>> Removing this older USB 3.0 DRD controller PHY driver, since
>>>> a new driver based on generic phy framework is now available.
>>>>
>>>> Also removing the dt node for older driver from Exynos5250
>>>> device tree and updating the dt node for DWC3 controller.
>>>>
>>>> Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>
>>>> ---
>>>>
>>>> NOTE: This patch should be merged only when the new USB 3.0
>>>> DRD phy controller driver is available in the tree from the
>>>> patches:
>>>>         phy: Add new Exynos5 USB 3.0 PHY driver; and
>>>>         dt: exynos5250: Enable support for generic USB DRD phy
>>>>
>>>>   arch/arm/boot/dts/exynos5250.dtsi  |   17 +-
>>>>   drivers/usb/phy/phy-samsung-usb.h  |   83 ---------
>>>>   drivers/usb/phy/phy-samsung-usb3.c |  350
>>>> ------------------------------------
>>>>   3 files changed, 2 insertions(+), 448 deletions(-)
>>>>   delete mode 100644 drivers/usb/phy/phy-samsung-usb3.c
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
>>>> b/arch/arm/boot/dts/exynos5250.dtsi
>>>> index 92c6fcd..1cb1e91 100644
>>>> --- a/arch/arm/boot/dts/exynos5250.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos5250.dtsi
>>>
>>>
>>> IMHO driver and dts changes should be separated into two patches, first
>>> updating device tree to use the new driver and second removing the driver.
>>
>> Sure will separate the patch into driver and dts change.
>>
>>>
>>> After fixing this issue,
>>>
>>> Reviewed-by: Tomasz Figa <t.figa@...sung.com>
>>>
> I guess you should also remove phy-samsung-usb3.c references in the
> Makefile, Kconfig and exynos_defconfig

You are correct. In fact i identified this issue once i submitted the patch :-(

I have amended the things in my next series which i will be posting soon.



Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/