lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140416164607.GJ1257@htj.dyndns.org>
Date:	Wed, 16 Apr 2014 12:46:07 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Jianyu Zhan <nasa4836@...il.com>
Cc:	gregkh@...uxfoundation.org, lizefan@...wei.com,
	linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org, cgroups@...r.kernel.org
Subject: Re: [PATCH] kernfs: move the last knowledge of sysfs out from kernfs

Hello,

On Thu, Apr 17, 2014 at 12:40:01AM +0800, Jianyu Zhan wrote:
> @@ -132,6 +132,7 @@ const void *kernfs_super_ns(struct super_block *sb)
>   * @flags: mount flags specified for the mount
>   * @root: kernfs_root of the hierarchy being mounted
>   * @new_sb_created: tell the caller if we allocated a new superblock
> + * @private: any file system specifc private data

Please put it before @new_sb_created.  Also, why isn't it unsigned
long magic?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ