linux-kernel - Re: [PATCH 1/2] workqueue: fix bugs in wq_update_unbound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140416173022.GN1257@htj.dyndns.org>
Date:	Wed, 16 Apr 2014 13:30:22 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	laijs@...fujitsu.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] workqueue: fix bugs in wq_update_unbound_numa()
 failure path

On Wed, Apr 16, 2014 at 02:32:29PM +0900, Daeseok Youn wrote:
> 
> wq_update_unbound_numa() failure path has the following two bugs.
>  - alloc_unbound_pwq() is called without holding wq->mutex;
>  however, if the allocation fails, it jumps to out_unlock
>  which tries to unlock wq->mutex.
> 
>  - The function should switch to dfl_pwq on failure
>  but didn't do so after alloc_unbound_pwq() failure.
> 
> Fix it by regrabbing wq->mutex and jumping to use_dfl_pwq on
> alloc_unbound_pwq() failure.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>

Applied to wq/for-3.15-fixes.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/