linux-kernel - Re: w1-gpio: sleeping function called from invalid context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <534ED833.6020303@windriver.com>
Date:	Wed, 16 Apr 2014 15:21:23 -0400
From:	Paul Gortmaker <paul.gortmaker@...driver.com>
To:	Stanislav Meduna <stano@...una.org>, <zbr@...emap.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-rt-users@...r.kernel.org" <linux-rt-users@...r.kernel.org>
Subject: Re: w1-gpio: sleeping function called from invalid context

On 14-04-16 10:46 AM, Stanislav Meduna wrote:
> Hi,
> 
> trying 1-wire with rt-patched Linux 3.12.15-rt25+ and lock debugging:

I didn't have 3.12-rt handy, but looking at vanilla 3.12, I see
that w1_touch_bit() turned off irqs via:

  static int w1_disable_irqs = 0;
  module_param_named(disable_irqs, w1_disable_irqs, int, 0);

...

  static void w1_write_bit(struct w1_master *dev, int bit)
  {
        unsigned long flags = 0;

        if(w1_disable_irqs) local_irq_save(flags);

...

so, if you are using the above module parameter, it will do the below
because gpiod_direction_output() does

spin_lock_irqsave(&gpio_lock, flags);

i.e. note it is not a raw lock, so it calls might_sleep, and then
you get the unravel below.

I've no idea why that module parameter exists.  Why do you set it?

Paul.
--

> 
> [   12.055550] BUG: sleeping function called from invalid context at /home/stano/Kernels/linux-3.12-rt/kernel/rtmutex.c:673
> [   12.055573] in_atomic(): 0, irqs_disabled(): 128, pid: 92, name: w1_bus_master1
> [   12.055588] 2 locks held by w1_bus_master1/92:
> [   12.055675]  #0:  (&dev->mutex){+.+...}, at: [<c0233560>] w1_process+0xbc/0xe0
> [   12.055729]  #1:  (&dev->bus_mutex){+.+...}, at: [<c0232a50>] w1_search+0x78/0x1e8
> [   12.055741] irq event stamp: 374
> [   12.055787] hardirqs last  enabled at (373): [<c02e04cc>] _raw_spin_unlock_irqrestore+0x6c/0x74
> [   12.055815] hardirqs last disabled at (374): [<c0234598>] w1_touch_bit+0x50/0xc4
> [   12.055860] softirqs last  enabled at (0): [<c001bacc>] copy_process+0x37c/0x1178
> [   12.055876] softirqs last disabled at (0): [<  (null)>]   (null)
> [   12.055899] CPU: 0 PID: 92 Comm: w1_bus_master1 Not tainted 3.12.15-rt25+ #66
> [   12.055973] [<c00151bc>] (unwind_backtrace+0x0/0xf4) from [<c0012c00>] (show_stack+0x10/0x14)
> [   12.056020] [<c0012c00>] (show_stack+0x10/0x14) from [<c02df920>] (rt_spin_lock+0x20/0x60)
> [   12.056080] [<c02df920>] (rt_spin_lock+0x20/0x60) from [<c01bc98c>] (gpiod_direction_output+0x50/0x2fc)
> [   12.056122] [<c01bc98c>] (gpiod_direction_output+0x50/0x2fc) from [<c02345ac>] (w1_touch_bit+0x64/0xc4)
> [   12.056156] [<c02345ac>] (w1_touch_bit+0x64/0xc4) from [<c0234794>] (w1_write_8+0x54/0x7c)
> [   12.056196] [<c0234794>] (w1_write_8+0x54/0x7c) from [<c0232a78>] (w1_search+0xa0/0x1e8)
> [   12.056239] [<c0232a78>] (w1_search+0xa0/0x1e8) from [<c0233414>] (w1_search_process_cb+0x50/0xe0)
> [   12.056280] [<c0233414>] (w1_search_process_cb+0x50/0xe0) from [<c0233570>] (w1_process+0xcc/0xe0)
> [   12.056334] [<c0233570>] (w1_process+0xcc/0xe0) from [<c003cf24>] (kthread+0xa0/0xa8)
> [   12.056379] [<c003cf24>] (kthread+0xa0/0xa8) from [<c000f3e0>] (ret_from_fork+0x14/0x34)
> 
> This happens reproducibly on any access.
> 
> Please Cc: me when replying
> 
> Thanks
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/