linux-kernel - Re: [PATCH] FMC: misc_register should not be called while atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140416211007.GA31451@kroah.com>
Date:	Wed, 16 Apr 2014 14:10:07 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Jet Chen <jet.chen@...el.com>
Cc:	Alessandro Rubini <rubini@...dd.com>,
	Fengguang Wu <fengguang.wu@...el.com>,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH] FMC: misc_register should not be called while atomic

On Wed, Apr 09, 2014 at 12:13:35PM +0800, Jet Chen wrote:
> Signed-off-by: Jet Chen <jet.chen@...el.com>
> ---
>  drivers/fmc/fmc-chardev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/fmc/fmc-chardev.c b/drivers/fmc/fmc-chardev.c
> index b071039..08c4549 100644
> --- a/drivers/fmc/fmc-chardev.c
> +++ b/drivers/fmc/fmc-chardev.c
> @@ -141,8 +141,8 @@ static int fc_probe(struct fmc_device *fmc)
>  	fc->misc.fops = &fc_fops;
>  	fc->misc.name = kstrdup(dev_name(&fmc->dev), GFP_KERNEL);
>  
> -	spin_lock(&fc_lock);
>  	ret = misc_register(&fc->misc);
> +	spin_lock(&fc_lock);
>  	if (ret < 0) {
>  		kfree(fc->misc.name);
>  		kfree(fc);
> -- 
> 1.9.1

This patch doesn't apply at all, can you please redo it against 3.15-rc1
and resend it so that I can apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/