linux-kernel - Re: [PATCH] usb: phy: mv_u3d: Remove usb phy driver for mv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1397721028.24336.13.camel@x220>
Date:	Thu, 17 Apr 2014 09:50:28 +0200
From:	Paul Bolle <pebolle@...cali.nl>
To:	balbi@...com
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Richard Weinberger <richard@....at>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] usb: phy: mv_u3d: Remove usb phy driver for mv_u3d

On Tue, 2014-04-15 at 23:34 -0500, Felipe Balbi wrote:
> $ make drivers/usb/phy/phy-mv-u3d-usb.o
>   CHK     include/config/kernel.release
>   CHK     include/generated/uapi/linux/version.h
>   CHK     include/generated/utsrelease.h
> make[1]: `include/generated/mach-types.h' is up to date.
>   CALL    scripts/checksyscalls.sh
>   CC      drivers/usb/phy/phy-mv-u3d-usb.o

(On x86_64 this manual make command triggers the error Greg reported in
https://lkml.org/lkml/2014/2/11/693 .)

> yup, builds just fine. Even if the ARCH support isn't in place, this
> driver is *not* breaking anything, it's not preventing anyone from
> getting work done and it might be helping Marvell decrease the amount of
> changes they keep out of tree.
> 
> I don't see any problems this driver in tree as long as there are people
> working on it and I see the latest commit was 10 days ago, it wouldn't
> be fair to Marvell to delete their driver if they're still finding ways
> to make it useful one way or another.

Wouldn't it then be better if this driver is at least hooked into the
build system? Like, say, this:
    config MV_U3D_PHY
            bool "Marvell USB 3.0 PHY controller Driver"
            # XXX should depend on CPU_MMP3 when support for MMP3 lands
            depends on ARM && COMPILE_TEST
            select USB_PHY
            help
              Enable this to support Marvell USB 3.0 phy controller for Marvell
              SoC.

(Or perhaps only ARCH_MMP && COMPILE_TEST.) That should give it build
coverage by the automated tests people appear to run, while work is done
on adding MMP3 support.

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/