linux-kernel - [PATCH] ipmi: fix seq number of bt msg in debug message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <534F9E0A.8050201@huawei.com>
Date:	Thu, 17 Apr 2014 17:25:30 +0800
From:	Xie XiuQi <xiexiuqi@...wei.com>
To:	Corey Minyard <minyard@....org>
CC:	<openipmi-developer@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: [PATCH] ipmi: fix seq number of bt msg in debug message

The seq number of HOST2BMC message in debug message
is not the real seq number but the next seq number;
we could directly just use bt->write_data[2].

pre:
[99477.760284] BT: +++++++++++++++++ New command
[99477.760286] BT: NetFn/LUN CMD [1 data]: 28 10 0c
[99477.760296] BT: write 5 bytes seq=0x88 04 28 87 10 0c
                                 ^^^^^^^^       ^^
[99477.772078] BT: got 8 bytes seq=0x87 07 2c 87 10 00 f8 07 00
[99477.772091] BT: result 6 bytes: 2c 10 00 f8 07 00

post:
[99477.760284] BT: +++++++++++++++++ New command
[99477.760286] BT: NetFn/LUN CMD [1 data]: 28 10 0c
[99477.760296] BT: write 5 bytes seq=0x87 04 28 87 10 0c
                                 ^^^^^^^^       ^^
[99477.772078] BT: got 8 bytes seq=0x87 07 2c 87 10 00 f8 07 00
[99477.772091] BT: result 6 bytes: 2c 10 00 f8 07 00

Signed-off-by: Xie XiuQi <xiexiuqi@...wei.com>
---
 drivers/char/ipmi/ipmi_bt_sm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/char/ipmi/ipmi_bt_sm.c b/drivers/char/ipmi/ipmi_bt_sm.c
index f5e4cd7..1a2056f 100644
--- a/drivers/char/ipmi/ipmi_bt_sm.c
+++ b/drivers/char/ipmi/ipmi_bt_sm.c
@@ -341,7 +341,7 @@ static inline void write_all_bytes(struct si_sm_data *bt)

 	if (bt_debug & BT_DEBUG_MSG) {
 		printk(KERN_WARNING "BT: write %d bytes seq=0x%02X",
-			bt->write_count, bt->seq);
+			bt->write_count, bt->write_data[2]);
 		for (i = 0; i < bt->write_count; i++)
 			printk(" %02x", bt->write_data[i]);
 		printk("\n");
-- 
1.6.0.2


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/