linux-kernel - Re: [PATCH 2/6] mfd: stmpe: add optional regulators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140417103018.GK28725@lee--X1>
Date:	Thu, 17 Apr 2014 11:30:18 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org,
	Silvio F <silvio.fricke@...il.com>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Shawn Guo <shawn.guo@...aro.org>,
	Viresh Kumar <viresh.linux@...il.com>,
	Shiraz Hashim <shiraz.hashim@...com>, spear-devel@...t.st.com
Subject: Re: [PATCH 2/6] mfd: stmpe: add optional regulators

> The STMPE has VCC and VIO supply lines, and sometimes (as on
> Ux500) this comes from a software-controlled regulator. Make
> it possible to supply the STMPE with power from these
> regulators.
> 
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  drivers/mfd/stmpe.c       | 18 ++++++++++++++++++
>  include/linux/mfd/stmpe.h |  5 +++++
>  2 files changed, 23 insertions(+)

[...]

> +	stmpe->vcc = devm_regulator_get_optional(ci->dev, "vcc");
> +	if (!IS_ERR(stmpe->vcc)) {
> +		ret = regulator_enable(stmpe->vcc);
> +		if (ret)
> +			dev_warn(ci->dev, "failed to enable VCC supply\n");
> +	}
> +	stmpe->vio = devm_regulator_get_optional(ci->dev, "vio");
> +	if (!IS_ERR(stmpe->vio)) {
> +		ret = regulator_enable(stmpe->vio);
> +		if (ret)
> +			dev_warn(ci->dev, "failed to enable VIO supply\n");
> +	}

[...]

>  int stmpe_remove(struct stmpe *stmpe)
>  {
> +	if (!IS_ERR(stmpe->vio))
> +		regulator_disable(stmpe->vio);
> +	if (!IS_ERR(stmpe->vcc))
> +		regulator_disable(stmpe->vcc);
> +

Genuine question:
  Doesn't the regulator core take care of this for you on removal?

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/