linux-kernel - Re: [PATCH v2] pwm_lpss: Add support for PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140417121643.2c07ecfc@alan.etchedpixels.co.uk>
Date:	Thu, 17 Apr 2014 12:16:43 +0100
From:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
To:	Thierry Reding <thierry.reding@...il.com>
Cc:	Chew Chiau Ee <chiau.ee.chew@...el.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	Alan Cox <alan@...ux.intel.com>, linux-pwm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] pwm_lpss: Add support for PCI devices

> > +static int pci_drv, plat_drv;	/* So we know which drivers registered */
> 
> I think that rather than having everything in a single file, perhaps a
> better approach would be to keep pwm-lpss.c as a common module and then
> have separate drivers for ACPI (pwm-lpss-acpi) and PCI (pwm-lpss-pci).
> That way you don't have to keep track of which driver was successfully
> registered.

It would then take up 16K for a tiny trivial piece of code

> Would that work?

Badly

> > +static const struct pwm_lpss_boardinfo byt_info = {
> 
> What does byt_ stand for?

Baytrail.

> > -static int pwm_lpss_probe(struct platform_device *pdev)
> > +static struct pwm_lpss_chip *pwm_lpss_probe(struct device *dev,
> > +			struct resource *r, struct pwm_lpss_boardinfo *info)
> 
> Indentation is odd here. Please align arguments one subsequent lines
> with those of the first.

That doesn't appear to be present in CodingStyle or indeed most of the
kernel.

> > -static struct platform_driver pwm_lpss_driver = {
> > +static int pwm_lpss_probe_pci(struct pci_dev *pdev,
> > +			      const struct pci_device_id *id)
> > +{
> > +	struct pwm_lpss_boardinfo *info;
> 
> I think this should be const to mirror the type of the byt_info
> variable.

Agreed

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/