linux-kernel - Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace system name.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140417114559.GB7422@krava.brq.redhat.com>
Date:	Thu, 17 Apr 2014 13:45:59 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Christian Borntraeger <borntraeger@...ibm.com>
Cc:	Paolo Bonzini <pbonzini@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	KVM <kvm@...r.kernel.org>,
	linux-s390 <linux-s390@...r.kernel.org>,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	linux-kernel@...r.kernel.org,
	Alexander Yarygin <yarygin@...ux.vnet.ibm.com>
Subject: Re: [PATCH] perf/tool: Fix usage of trace events with '-' in trace
 system name.

On Thu, Apr 17, 2014 at 01:41:56PM +0200, Christian Borntraeger wrote:
> On 17/04/14 13:32, Jiri Olsa wrote:
> > On Tue, Mar 25, 2014 at 11:15:29AM +0100, Paolo Bonzini wrote:
> >> Il 24/03/2014 21:49, Christian Borntraeger ha scritto:
> >>> event_legacy_tracepoint:
> >>> +PE_NAME '-' PE_NAME ':' PE_NAME
> >>> +{
> >>> +	struct parse_events_evlist *data = _data;
> >>> +	struct list_head *list;
> >>> +	char sys_name[strlen($1) + strlen($3) + 2];
> >>> +	sprintf(&sys_name, "%s-%s", $1, $3);
> >>> +
> >>> +	ALLOC_LIST(list);
> >>> +	ABORT_ON(parse_events_add_tracepoint(list, &data->idx, &sys_name, $5));
> >>> +	$$ = list;
> >>> +}
> >>
> >> Why isn't '-' part of PE_NAME?
> > 
> > hi Paolo ;-)
> > 
> > because it screws cache events parsing.. we need some code factoring
> > in this part
> > 
> > Acked-by: Jiri Olsa <jolsa@...hat.com>
> 
> Jiri,
> 
> can you handle this patch + "perf-kvm: fix of 'Min time' counting in report command" in your tree?

yep, I queued both of them

jirka

> 
> > 
> > it'd be nice to add test to tests/parse-events.c, probably s390 specific,
> > because the parsing code touches the tracepoint format file
> 
> Alexander,
> 
> can you have a look to provide a simple test for perf that checks that trace events like kvm-s390 are handled properly?
> 
> Thanks
> 
> Christian
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/