linux-kernel - Re: [PATCH v4] control groups: documentation improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <534FDB04.6050406@gopivotal.com>
Date:	Thu, 17 Apr 2014 14:45:40 +0100
From:	Glyn Normington <gnormington@...ivotal.com>
To:	Tejun Heo <tj@...nel.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] control groups: documentation improvements

Hi Tejun

On 17/04/2014 14:16, Tejun Heo wrote:
> Hello, Glyn.
>
> On Thu, Apr 17, 2014 at 11:46:13AM +0100, Glyn Normington wrote:
>> +There may be zero or more active hierarchies. Each hierarchy has an
>> +instance of the cgroup virtual filesystem associated with it. The tree
>> +of cgroups is represented by the directory tree in the cgroup virtual
>> +filesystem.
>> +
>> +The sets of subsystems participating in distinct hierarchies are either
>> +identical or disjoint. If the sets are identical, the virtual filesystems
>> +associated with the hierarchies have identical content and a change in
>> +one is automatically reflected in all the others.
> I can't say I'm a big fan of these definitions in mathematical terms.
> They're so precise and useless at the same time.
We would like to be both precise and readable. Please point out the 
"useless" bits and we'll try to make them better.
> That said, I don't
> really understand the last paragraph.  Is it trying to talk about
> multiple mounts of a single hierarchy?
Yes. When this came up earlier, Li Zefan thought we could delete that 
paragraph "because we all know the same filesystem can have more than 
one mount point and cgroupfs is no different". But since the underlying 
cgroupfs is only visible through the representation(s) at its mount 
points, we'd prefer to keep the paragraph.

How about changing the  paragraph to say:

A given hierarchy may be associated with more than one virtual 
filesystem, in which case each of the virtual filesystems has identical 
contents to the others.

?
>
> Thanks.
Regards,
Glyn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/