linux-kernel - Re: [PATCH] cgroup: fix the retry path of cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140417152048.GL15326@htj.dyndns.org>
Date:	Thu, 17 Apr 2014 11:20:48 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Li Zefan <lizefan@...wei.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Cgroups <cgroups@...r.kernel.org>
Subject: Re: [PATCH] cgroup: fix the retry path of cgroup_mount()

On Thu, Apr 17, 2014 at 01:53:08PM +0800, Li Zefan wrote:
> If we hit the retry path, we'll call parse_cgroupfs_options() again,
> but the string we pass to it has been modified by the previous call
> to this function.
> 
> This bug can be observed by:
> 
>   # mount -t cgroup -o name=foo,cpuset xxx /mnt && umount /mnt && \
>     mount -t cgroup -o name=foo,cpuset xxx /mnt
>   mount: wrong fs type, bad option, bad superblock on xxx,
>          missing codepage or helper program, or other error
>   ...
> 
> The second mount passed "name=foo,cpuset" to the parser, and then it
> hit the retry path and call the parser again, but this time the string
> passed to the parser is "name=foo".
> 
> To fix this, we avoid calling parse_cgroupfs_options() again in this
> case.
> 
> Signed-off-by: Li Zefan <lizefan@...wei.com>

Applied to cgroup/for-3.15-fixes.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/