linux-kernel - Re: [PATCH v2] usb: gadget: fsl: Set dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140417152851.GA22861@saruman.home>
Date:	Thu, 17 Apr 2014 10:28:51 -0500
From:	Felipe Balbi <balbi@...com>
To:	Suresh Gupta <suresh.gupta@...escale.com>
CC:	<balbi@...com>, <gregkh@...uxfoundation.org>,
	<linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	Suresh Gupta <B42813@...escale.com>
Subject: Re: [PATCH v2] usb: gadget: fsl: Set dma_ops for FSL USB Gadget
 Device

Hi,

On Fri, Mar 21, 2014 at 01:56:49AM +0530, Suresh Gupta wrote:
> From: Suresh Gupta <B42813@...escale.com>
> 
> DMA mapping functions are moved to common place in udc_core.c
> which expect the DMA operation of gadget device
> 
> Signed-off-by: Suresh Gupta <B42813@...escale.com>
> ---
> Changes from previous version:
> * Added description
> 
>  drivers/usb/gadget/fsl_udc_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
> index d68aa77..35cb972 100644
> --- a/drivers/usb/gadget/fsl_udc_core.c
> +++ b/drivers/usb/gadget/fsl_udc_core.c
> @@ -2456,6 +2456,7 @@ static int __init fsl_udc_probe(struct platform_device *pdev)
>  	/* Setup gadget.dev and register with kernel */
>  	dev_set_name(&udc_controller->gadget.dev, "gadget");
>  	udc_controller->gadget.dev.of_node = pdev->dev.of_node;
> +	set_dma_ops(&udc_controller->gadget.dev, pdev->dev.archdata.dma_ops);

I'm still not convinced this is the best thing to do in a driver.
set_dma_ops() isn't even exposed on include/linux/ and no other driver
tries to call it. This is really something that should be done at arch
level.

Perhaps send a note to lakml and see if anybody has a better idea ?

cheers

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)