lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.44L0.1404171149001.881-100000@iolanthe.rowland.org>
Date:	Thu, 17 Apr 2014 11:50:47 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Oliver Neukum <oneukum@...e.de>
cc:	linux-kernel@...r.kernel.org
Subject: Re: question on read_barrier_depends

On Thu, 17 Apr 2014, Oliver Neukum wrote:

> On Wed, 2014-04-16 at 11:26 -0400, Alan Stern wrote:
> 
> > In addition, the following code in kfifo_get() does this:
> > 
> > 			*(typeof(__tmp->type))__val = \
> > 				(__is_kfifo_ptr(__tmp) ? \
> > 				((typeof(__tmp->type))__kfifo->data) : \
> > 				(__tmp->buf) \
> > 				)[__kfifo->out & __tmp->kfifo.mask]; \
> > 			smp_wmb(); \
> > 			__kfifo->out++; \
> > 
> > It looks like the smp_wmb() should really be smp_mb(), because it 
> > separates the _read_ for val from the _write_ of kfifo->out.
> 
> But where is kfifo->out read at all?

It is read in kfifo_put(), inside the call to kfifo_is_full() -> 
kfifo_len().

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ