linux-kernel - Re: [tip:x86/urgent] x86/mce: Fix CMCI preemption bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+5PVA7i=RrGUk_7zz1yU5gseWpvr+a=4dfkg=n9cNc53S7nPA@mail.gmail.com>
Date:	Thu, 17 Apr 2014 12:54:21 -0400
From:	Josh Boyer <jwboyer@...oraproject.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	"Luck, Tony" <tony.luck@...el.com>,
	Peter Zijlstra <peterz@...radead.org>,
	"mingo@...nel.org" <mingo@...nel.org>,
	"hpa@...or.com" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
	"atodorov@...hat.com" <atodorov@...hat.com>,
	"gong.chen@...ux.intel.com" <gong.chen@...ux.intel.com>,
	"qmewlo@...il.com" <qmewlo@...il.com>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"linux-tip-commits@...r.kernel.org" 
	<linux-tip-commits@...r.kernel.org>
Subject: Re: [tip:x86/urgent] x86/mce: Fix CMCI preemption bugs

On Thu, Apr 17, 2014 at 11:26 AM, Borislav Petkov <bp@...en8.de> wrote:
> On Thu, Apr 17, 2014 at 02:03:34PM +0000, Luck, Tony wrote:
>> > Hohum, __raw_spin_lock_irqsave does preempt_disable(). And
>> > machine_check_poll should be running in irq context so why would the
>> > original issue happen?
>> >
>> >> kernel: [    7.341085] BUG: using __this_cpu_write() in preemptible [00000000] code: modprobe/546
>> >
>> > Unfortunately, I have only one line in a mail CCed to me.
>> >
>> > Color me confused.
>>
>> Is this just the missing put_cpu() that Chen Gong already sent a patch for?
>
> I'm not sure. There's some bug report floating around which contains the
> "BUG" line above but I can't seem to find/get it.
>
> I'll boot latest Linus tree on my SNB machine to check whether it
> triggers here. Ingo says CONFIG_DEBUG_PREEMPT=y is causing it but this
> is all hearsay stuff from where I'm standing...

For some context.

A user (Owen) reported seeing the following backtrace with 3.15-rc1+:

kernel: [  120.253539] Hardware name: Hewlett-Packard HP ENVY 15
Notebook PC/1962, BIOS F.24 08/27/2013
kernel: [  120.253540]  ffff88025f2146c0 ffffffff81c01e40
ffffffff8171dc1d ffffffff81d11aa0
kernel: [  120.253543]  ffffffff81c01e50 ffffffff81719a39
ffffffff81c01eb0 ffffffff8172151b
kernel: [  120.253545]  ffffffff81c18480 ffffffff81c01fd8
00000000000146c0 00000000000146c0
kernel: [  120.253548] Call Trace:
kernel: [  120.253555]  [<ffffffff8171dc1d>] dump_stack+0x4d/0x6f
kernel: [  120.253558]  [<ffffffff81719a39>] __schedule_bug+0x4c/0x5a
kernel: [  120.253560]  [<ffffffff8172151b>] __schedule+0x6eb/0x7a0
kernel: [  120.253563]  [<ffffffff81721b91>] schedule_preempt_disabled+0x31/0x80
kernel: [  120.253566]  [<ffffffff810af8f3>] cpu_startup_entry+0x173/0x490
kernel: [  120.253570]  [<ffffffff8170e3e4>] rest_init+0x84/0x90
kernel: [  120.253574]  [<ffffffff81d34f83>] start_kernel+0x450/0x45b
kernel: [  120.253576]  [<ffffffff81d3493c>] ? repair_env_string+0x5c/0x5c
kernel: [  120.253578]  [<ffffffff81d34120>] ? early_idt_handlers+0x120/0x120
kernel: [  120.253581]  [<ffffffff81d345ee>] x86_64_start_reservations+0x2a/0x2c
kernel: [  120.253583]  [<ffffffff81d3472e>] x86_64_start_kernel+0x13e/0x14d

For whatever reason, his report didn't hit lkml, but it did hit Linus'
inbox.  Linus took a look around, googled some, and came across a
report that Alexander filed 2 days ago against Fedora rawhide with a
similar backtrace:

https://bugzilla.redhat.com/show_bug.cgi?id=1087810

Linus CC'd me and Alexander on his reply to Owen, Ingo, Peter, etc.
Ingo was aware of Chen Gong's patch, but when Owen tested it it
produced the BUG line above.  So Ingo came up with a slightly
different fix to hopefully resolve that as well.  We haven't heard
from Owen whether Ingo's patch resolves everything yet.

I think (hope) that is the full backstory.  Ingo or Peter could correct me.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/