linux-kernel - Re: [PATCH] FMC: misc_register should not be called while atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140417030925.GA7486@kroah.com>
Date:	Wed, 16 Apr 2014 20:09:25 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Alessandro Rubini <rubini@...dd.com>
Cc:	jet.chen@...el.com, fengguang.wu@...el.com,
	linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH] FMC: misc_register should not be called while atomic

On Thu, Apr 17, 2014 at 12:39:42AM +0200, Alessandro Rubini wrote:
> >> --- a/drivers/fmc/fmc-chardev.c
> >> +++ b/drivers/fmc/fmc-chardev.c
> >> @@ -141,8 +141,8 @@ static int fc_probe(struct fmc_device *fmc)
> >>  	fc->misc.fops = &fc_fops;
> >>  	fc->misc.name = kstrdup(dev_name(&fmc->dev), GFP_KERNEL);
> >>  
> >> -	spin_lock(&fc_lock);
> >>  	ret = misc_register(&fc->misc);
> >> +	spin_lock(&fc_lock);
> >>  	if (ret < 0) {
> >>  		kfree(fc->misc.name);
> >>  		kfree(fc);
> >> -- 
> >> 1.9.1
> 
> This is already applied, though in a slightly different way. Commit
> 783c2fb1b. I fixed it in Jul 13 2013 after user reports.
> 
> "git tag --contains 783c2fb1b" reports v3.12-rc1 and later

Then why in the world is it being submitted as a patch to be included?
What is going on here?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/