linux-kernel - Re: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140418045828.GA31103@gondor.apana.org.au>
Date:	Fri, 18 Apr 2014 12:58:29 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Marek Vasut <marex@...x.de>, Jianyu Zhan <nasa4836@...il.com>,
	davem@...emloft.net, tglx@...utronix.de, mingo@...hat.com,
	x86@...nel.org, linux-crypto@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from
 static functions

On Thu, Apr 17, 2014 at 09:49:56PM -0700, H. Peter Anvin wrote:
> On 04/17/2014 08:28 AM, Marek Vasut wrote:
> > On Wednesday, April 16, 2014 at 06:19:50 PM, Jianyu Zhan wrote:
> >> Commit 128ea04a9885("lto: Make asmlinkage __visible") restricts
> >> asmlinkage to externally_visible, this causes compilation warnings:
> >>
> >>     arch/x86/crypto/sha256_ssse3_glue.c:56:1:
> >>     warning: ‘externally_visible’ attribute have effect only on public
> >> objects [-Wattributes]
> >>
> >>     static asmlinkage void (*sha256_transform_asm)(const char *, u32 *,
> >> u64); ^
> >>
> >>     arch/x86/crypto/sha512_ssse3_glue.c:55:1:
> >>     warning: ‘externally_visible’ attribute have effect only on public
> >> objects [-Wattributes] static asmlinkage void
> >> (*sha512_transform_asm)(const char *, u64 *, ^
> >>
> >> Drop asmlinkage here to avoid such warnings.
> >>
> >> Also see Commit 8783dd3a37a5853689e1("irqchip: Remove asmlinkage from
> >> static functions")
> >>
> >> Signed-off-by: Jianyu Zhan <nasa4836@...il.com>
> > 
> > Makes sense, please add my humble
> > 
> > Reviewed-by: Marek Vasut <marex@...x.de>
> > 
> 
> It doesn't make sense, sorry.  The right thing to drop here is not
> "asmlinkage", it is "static": this is an external declaration.

It's a function pointer that's static, not the function that
it's pointing to.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/