linux-kernel - Re: [PATCH 07/10] ARM: bcm: tidy up a few includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <535114F7.20307@linaro.org>
Date:	Fri, 18 Apr 2014 07:05:11 -0500
From:	Alex Elder <elder@...aro.org>
To:	Russell King - ARM Linux <linux@....linux.org.uk>
CC:	bcm@...thebug.org, mporter@...aro.org,
	bcm-kernel-feedback-list@...adcom.com,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 07/10] ARM: bcm: tidy up a few includes

On 04/18/2014 03:29 AM, Russell King - ARM Linux wrote:
> On Thu, Apr 17, 2014 at 09:30:12PM -0500, Alex Elder wrote:
>> Clean up a few header file includes, eliminating a few that are not
>> really needed and putting in their place some that are.
>>
>> Signed-off-by: Alex Elder <elder@...aro.org>
>> Reviewed-by: Matt Porter <mporter@...aro.org>
>> ---
>>  arch/arm/mach-bcm/board_bcm21664.c |    3 +--
>>  arch/arm/mach-bcm/kona.c           |    5 +++--
>>  arch/arm/mach-bcm/kona.h           |    1 +
>>  3 files changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/arm/mach-bcm/board_bcm21664.c b/arch/arm/mach-bcm/board_bcm21664.c
>> index acc1573..ab96c3f 100644
>> --- a/arch/arm/mach-bcm/board_bcm21664.c
>> +++ b/arch/arm/mach-bcm/board_bcm21664.c
>> @@ -11,13 +11,12 @@
>>   * GNU General Public License for more details.
>>   */
>>  
>> -#include <linux/clocksource.h>
>>  #include <linux/of_address.h>
>>  #include <linux/of_platform.h>
>>  
>>  #include <asm/mach/arch.h>
>> +#include <asm/io.h>
> 
> It's linux/io.h

Fixed, as you'll see when I post v2 later.

>> diff --git a/arch/arm/mach-bcm/kona.h b/arch/arm/mach-bcm/kona.h
>> index 110185f..bcdcf06 100644
>> --- a/arch/arm/mach-bcm/kona.h
>> +++ b/arch/arm/mach-bcm/kona.h
>> @@ -12,6 +12,7 @@
>>   */
>>  
>>  #ifdef CONFIG_ARCH_BCM_MOBILE_L2_CACHE
>> +#include <linux/init.h>
>>  
>>  void __init kona_l2_cache_init(void);
> 
> Just get rid of the __init instead.

Because __init is a "section" attribute, which affects
code and not the prototype.  That's great, thanks a lot.

					-Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/