linux-kernel - Re: [PATCH v2 2/2] regmap: i2c: fallback to SMBus if the adapter does not support standard I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140418151056.GY12304@sirena.org.uk>
Date:	Fri, 18 Apr 2014 16:10:56 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Boris BREZILLON <boris.brezillon@...e-electrons.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Maxime Ripard <maxime.ripard@...e-electrons.com>,
	Shuge <shuge@...winnertech.com>, kevin@...winnertech.com,
	Chen-Yu Tsai <wens@...e.org>,
	Hans de Goede <hdegoede@...hat.com>,
	Carlo Caione <carlo@...one.org>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	dev@...ux-sunxi.org
Subject: Re: [PATCH v2 2/2] regmap: i2c: fallback to SMBus if the adapter
 does not support standard I2C

On Thu, Apr 17, 2014 at 11:40:12AM +0200, Boris BREZILLON wrote:

> +const struct regmap_bus *regmap_get_i2c_bus(struct i2c_client *i2c,
> +					    const struct regmap_config *config)

Non-exported functions should be static.  Otherwise this looks good
modulo the register size issue that Guenter identified.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)