linux-kernel - Re: [PATCH 2/8] idr: fix unexpected id-removal when idr_remove(unallocated

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140418165705.GE12515@htj.dyndns.org>
Date:	Fri, 18 Apr 2014 12:57:05 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Lai Jiangshan <laijs@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Jean Delvare <jdelvare@...e.de>,
	Monam Agarwal <monamagarwal123@...il.com>,
	Jeff Layton <jlayton@...hat.com>,
	Andreas Gruenbacher <agruen@...bit.com>,
	Stephen Hemminger <stephen@...workplumber.org>
Subject: Re: [PATCH 2/8] idr: fix unexpected id-removal when
 idr_remove(unallocated_id)

On Fri, Apr 18, 2014 at 08:49:49PM +0800, Lai Jiangshan wrote:
> If unallocated_id = (ANY * idr_max(idp->layers) + existed_id) is passed

						    existing_id

> to idr_remove(). The existed_id will be removed unexpected.

                       ditto.

> 
> The following test shows this unexpected id-removal:
> 
> static void test4(void)
> {
> 	int id;
> 	DEFINE_IDR(test_idr);
> 
> 	printk(KERN_INFO "Start test4\n");
> 	id = idr_alloc(&test_idr, (void *)1, 42, 43, GFP_KERNEL);
> 	BUG_ON(id != 42);
> 	idr_remove(&test_idr, 42 + IDR_SIZE);
> 	TEST_BUG_ON(idr_find(&test_idr, 42) != (void *)1);
> 	idr_destroy(&test_idr);
> 	printk(KERN_INFO "End of test4\n");
> }
> 
> It only happens when unallocated_id, it is caller's fault. It is not
> a bug. But it is better to add the proper check and complains instead

							complain

> of removing an existed_id silently.

                existing_id

> Signed-off-by: Lai Jiangshan <laijs@...fujitsu.com>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/