| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 18 Apr 2014 10:54:33 -0700 From: Bryan Wu <cooloney@...il.com> To: Jacek Anaszewski <j.anaszewski@...sung.com> Cc: "linux-media@...r.kernel.org" <linux-media@...r.kernel.org>, Linux LED Subsystem <linux-leds@...r.kernel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, lkml <linux-kernel@...r.kernel.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>, Andrzej Hajda <a.hajda@...sung.com>, Kyungmin Park <kyungmin.park@...sung.com> Subject: Re: [PATCH/RFC v3 0/5] LED / flash API integration On Fri, Apr 11, 2014 at 7:56 AM, Jacek Anaszewski <j.anaszewski@...sung.com> wrote: > This is is the third version of the patch series being a follow up > of the discussion on Media summit 2013-10-23, related to the > LED / flash API integration (the notes from the discussion were > enclosed in the message [1], paragraph 5). > The series is based on linux-next next-20140328 > > Description of the proposed modifications according to > the kernel components they are relevant to: > - LED subsystem modifications > * added led_flash module which, when enabled in the config, > registers flash specific sysfs attributes: > - flash_brightness > - max_flash_brightness > - indicator_brightness > - max_indicator_brightness > - flash_timeout > - max_flash_timeout > - flash_strobe > - flash_fault > - external_strobe > and exposes kernel internal API > - led_set_flash_strobe > - led_get_flash_strobe > - led_set_indicator_brightness > - led_update_indicator_brightness > - led_set_flash_timeout > - led_get_flash_fault > - led_set_external_strobe > - led_sysfs_lock > - led_sysfs_unlock > - Addition of a V4L2 Flash sub-device registration helpers > * added v4l2-flash.c and v4l2-flash.h files with helper > functions that facilitate registration/unregistration > of a subdevice, which wrapps a LED subsystem device and > exposes V4L2 Flash control interface > - Addition of a driver for the flash cell of the MAX77693 mfd > * the driver exploits the newly introduced mechanism > - Update of the max77693.txt DT bindings documentation > > ================ > Changes since v2 > ================ > > - refactored the code so that it is possible to build > led-core without led-flash module > - added v4l2-flash ops which slackens dependency from > the led-flash module > - implemented led_clamp_align_val function and led_ctrl > structure which allows to align led control values > in the manner compatible with V4L2 Flash controls; > the flash brightness and timeout units have been defined > as microamperes and microseconds respectively to properly > support devices which define current and time levels > as fractions of 1/1000. > - added support for the flash privacy leds > - modified LED sysfs locking mechanism - now it locks/unlocks > the interface on V4L2 Flash sub-device file open/close > - changed hw_triggered attribute name to external_strobe, > which maps on the V4L2_FLASH_STROBE_SOURCE_EXTERNAL name > more intuitively > - made external_strobe and indicator related sysfs attributes > created optionally only if related features are declared > by the led device driver > - removed from the series patches modifying exynos4-is media > controller - a proposal for "flash manager" which will take > care of flash devices registration is due to be submitted > - removed modifications to the LED class devices documentation, > it will be covered after the whole functionality is accepted > Thanks a lot for pushing this, I'm trapping in some other urgent tasks and will review it soon when I'm free. -Bryan > Thanks, > Jacek Anaszewski > > [1] http://www.spinics.net/lists/linux-media/msg69253.html > > Jacek Anaszewski (5): > leds: Add sysfs and kernel internal API for flash LEDs > leds: Improve and export led_update_brightness function > leds: Add support for max77693 mfd flash cell > DT: Add documentation for the mfd Maxim max77693 flash cell > media: Add registration helpers for V4L2 flash sub-devices > > Documentation/devicetree/bindings/mfd/max77693.txt | 57 ++ > drivers/leds/Kconfig | 18 + > drivers/leds/Makefile | 2 + > drivers/leds/led-class.c | 42 +- > drivers/leds/led-core.c | 16 + > drivers/leds/led-flash.c | 627 ++++++++++++++++ > drivers/leds/led-triggers.c | 16 +- > drivers/leds/leds-max77693.c | 794 ++++++++++++++++++++ > drivers/leds/leds.h | 6 + > drivers/media/v4l2-core/Kconfig | 10 + > drivers/media/v4l2-core/Makefile | 2 + > drivers/media/v4l2-core/v4l2-flash.c | 393 ++++++++++ > drivers/mfd/max77693.c | 2 +- > include/linux/leds.h | 60 +- > include/linux/leds_flash.h | 252 +++++++ > include/linux/mfd/max77693.h | 38 + > include/media/v4l2-flash.h | 119 +++ > 17 files changed, 2433 insertions(+), 21 deletions(-) > create mode 100644 drivers/leds/led-flash.c > create mode 100644 drivers/leds/leds-max77693.c > create mode 100644 drivers/media/v4l2-core/v4l2-flash.c > create mode 100644 include/linux/leds_flash.h > create mode 100644 include/media/v4l2-flash.h > > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-leds" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists