linux-kernel - Re: [PATCH] kdb: Put a cr before lf when working w/ a non open console port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=Wfus8noqMUmO5dWELwjO2z1V1XaH5SxQu7WVGRdRsA9g@mail.gmail.com>
Date:	Fri, 18 Apr 2014 16:53:33 -0700
From:	Doug Anderson <dianders@...omium.org>
To:	Jason Wessel <jason.wessel@...driver.com>
Cc:	Doug Anderson <dianders@...omium.org>,
	kgdb-bugreport@...ts.sourceforge.net,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kdb: Put a cr before lf when working w/ a non open
 console port

Hi,

On Fri, Apr 18, 2014 at 10:17 AM, Doug Anderson <dianders@...omium.org> wrote:
> In (efe2f29 kgdboc,kdb: Allow kdb to work on a non open console port)
> support was added to directly use the "write_char" functions when
> doing kdb over a non-open console port.  This is great, but it ends up
> bypassing the normal code in uart_console_write() that adds a carriage
> return before any newlines.
>
> Add similar code in kdb so we don't get things like:
> [0]kdb>
>        [0]kdb>
>               [0]kdb>
>
> Signed-off-by: Doug Anderson <dianders@...omium.org>
> ---
>  kernel/debug/kdb/kdb_io.c | 6 ++++++
>  1 file changed, 6 insertions(+)

I've been digging through the code and I've finally figured out where
this happens on some other platforms (I'm using samsung/serial
myself).

The 8250 driver has it hardcoded in serial8250_put_poll_char().  Next
week I'll include a removal of that code with v2 of this patch unless
I hear any objections.  I think doing things in kdb_io is nice
because:

* we don't need to duplicate the code in everyone's "put_poll_char" functions.

* we don't end up running the code in kgdb mode, only in kdb mode.

I could also move my change to be in uart_poll_put_char() which
_would_ (I believe) apply to both kdb / kgdb if that was desirable for
some reason.

-Doug
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/