linux-kernel - Re: [PATCH] tracing: Correct braces usage in if-else statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140419112821.6ee5b104@gandalf.local.home>
Date:	Sat, 19 Apr 2014 11:28:21 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Lin Yongting <linyongting@...il.com>
Cc:	fweisbec@...il.com, mingo@...hat.com, linux-kernel@...r.kernel.org,
	linyongting@...wei.com
Subject: Re: [PATCH] tracing: Correct braces usage in if-else statement

On Sat, 19 Apr 2014 21:58:23 +0800
Lin Yongting <linyongting@...il.com> wrote:

> There are some incorrect braces usages in kernerl/trace/trace.c, including:
> 1. Missing braces in 'if' or 'else' branch.
> 2. Unnecessary braces in 'if' statement.
> 
> Fix them according to kernel CodeStyle.

I understand that this is part of the CodeStyle, but I'm not accepting
this patch. It causes more pain than it is worth, as it makes it more
difficult to see git history because of "clean up" changes that get in
the way. I also honestly don't think this is much of a clean up.

Sorry,

-- Steve


> 
> Signed-off-by: Lin Yongting <linyongting@...il.com>
> ---
>  kernel/trace/trace.c |   39 +++++++++++++++++++++++----------------
>  1 file changed, 23 insertions(+), 16 deletions(-)
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/