linux-kernel - Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <B2C4D47E-30F0-4CC3-B3AD-22C791F61614@kernel.dk>
Date:	Fri, 18 Apr 2014 22:05:04 -0700
From:	Jens Axboe <axboe@...nel.dk>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	Jörg-Volker Peetz <jvpeetz@....de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH next 3/4] blk-mq: user (1 << order) to implement order_to_size()

On Apr 18, 2014, at 8:17 PM, Ming Lei <tom.leiming@...il.com> wrote:
> 
>> On Sat, Apr 19, 2014 at 3:23 AM, Jörg-Volker Peetz <jvpeetz@....de> wrote:
>> 
>> Testing this with gcc 4.8.2 with order > 30 confirms that the automatic casting
>> is done operator-wise and the explicit casting is necessary.
> 
> My gcc 4.8.2 doesn't complain the change, see below:

It won't complain, but that doesn't mean that it won't get it wrong. The cast is necessary.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/