linux-kernel - Re: [PATCH] fix the code style errors in sn9c102

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHz2CGVVf6tFsPRX90PZDHrWMoEd2Jn+2x3Rex-b2J0+2CZOSA@mail.gmail.com>
Date:	Sat, 19 Apr 2014 14:41:19 +0800
From:	Jianyu Zhan <nasa4836@...il.com>
To:	Jinqiang Zeng <jinqiangzeng@...il.com>
Cc:	Luca Risolia <luca.risolia@...dio.unibo.it>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-media@...r.kernel.org,
	devel@...verdev.osuosl.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fix the code style errors in sn9c102

On Sat, Apr 19, 2014 at 11:09 AM, Jinqiang Zeng <jinqiangzeng@...il.com> wrote:
> ---
>  drivers/staging/media/sn9c102/sn9c102.h            |   30 +-
>  drivers/staging/media/sn9c102/sn9c102_core.c       |  342 ++++++++++----------
>  drivers/staging/media/sn9c102/sn9c102_devtable.h   |   22 +-
>  drivers/staging/media/sn9c102/sn9c102_hv7131d.c    |   22 +-
>  drivers/staging/media/sn9c102/sn9c102_hv7131r.c    |   22 +-
>  drivers/staging/media/sn9c102/sn9c102_mi0343.c     |   30 +-
>  drivers/staging/media/sn9c102/sn9c102_mi0360.c     |   30 +-
>  drivers/staging/media/sn9c102/sn9c102_ov7630.c     |   22 +-
>  drivers/staging/media/sn9c102/sn9c102_ov7660.c     |   22 +-
>  drivers/staging/media/sn9c1

Hi, Jinqiang,

you just missed something.
1. a "Signed-off-by" line, if you use git, git-format-patch is a good tool.;-)
2. better add a module name in cover later, like this:
     "sn9c102: fix the coding style errors"
3. maybe some changelog is good, but for this patch, leaving it out is OK.

You would better read the "Documentation/SubmittingPatches" .

Thanks,
Jianyu Zhan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/