linux-kernel - Re: [PATCH v2 0/2] staging: panel: fix sparse warnings.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140420062437.GB4037@1wt.eu>
Date:	Sun, 20 Apr 2014 08:24:37 +0200
From:	Willy Tarreau <w@....eu>
To:	Bastien Armand <armand.bastien@...oste.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Monam Agarwal <monamagarwal123@...il.com>,
	Jake Champlin <jake.champlin.27@...il.com>,
	Arnd Bergmann <arnd@...db.de>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] staging: panel: fix sparse warnings.

Hi Bastien,

On Fri, Apr 18, 2014 at 06:09:18PM +0200, Bastien Armand wrote:
> This serie of two patch fix the following sparse warnings in panel.c :
> panel.c:1235:26: warning: incorrect type in argument 1 (different address spaces)
> panel.c:1235:26:    expected void const volatile [noderef] <asn:1>*<noident>
> panel.c:1235:26:    got char const *tmp
> panel.c:1353:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> panel.c:1353:20:    expected int ( *write )( ... )
> panel.c:1353:20:    got int ( static [toplevel] *<noident> )( ... )
> panel.c:1591:17: warning: incorrect type in argument 1 (different address spaces)
> panel.c:1591:17:    expected void const volatile [noderef] <asn:1>*<noident>
> panel.c:1591:17:    got char *tmp
> panel.c:1620:20: warning: incorrect type in initializer (incompatible argument 2 (different address spaces))
> panel.c:1620:20:    expected int ( *read )( ... )
> panel.c:1620:20:    got int ( static [toplevel] *<noident> )( ... )
> 
> Changes since v1 :
> - splitted patch in two
> 
> Bastien Armand (2):
>   staging: panel: fix sparse warnings in keypad_read
>   staging: panel: fix sparse warnings in lcd_write

Just reviewed them both and I'm fine with these patches. You can
add my :

    Acked-by: Willy Tarreau <w@....eu>

Willy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/