linux-kernel - Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140420105419.GB19676@pd.tnic>
Date:	Sun, 20 Apr 2014 12:54:19 +0200
From:	Borislav Petkov <bp@...e.de>
To:	Myron Stowe <myron.stowe@...hat.com>
Cc:	bhelgaas@...gle.com, linux-pci@...r.kernel.org,
	suravee.suthikulpanit@....com, aravind.gopalakrishnan@....com,
	kim.naru@....com, daniel@...ascale.com, tglx@...utronix.de,
	mingo@...hat.com, hpa@...or.com, x86@...nel.org, sp@...ascale.com,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 5/5] PCI: Remove redundant 'quirk_amd_nb_node'

On Fri, Apr 18, 2014 at 08:53:46PM -0600, Myron Stowe wrote:
> With the amd_bus.c updates to support additional AMD processors (11h, 12h,
> 14h 15h  and 16h) 'quirk_amd_nb_node' seems to be redundant.  This patch
> removes it.
> 
> Signed-off-by: Myron Stowe <myron.stowe@...hat.com>

Good idea. Has this been tested, though? There are a bunch of places
using dev_to_node() which this quirk corrects, especially 'local_cpus'
in a bunch of sysfs nodes in the PCI hierarchy /sys/devices/pci*.

We want to make sure this doesn't break that and other dev_to_node()
callsites.

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/