linux-kernel - Re: [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator device node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140421122205.GB3461@piout.net>
Date:	Mon, 21 Apr 2014 14:22:05 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Wenyou Yang <wenyou.yang@...el.com>
Cc:	devicetree@...r.kernel.org, nicolas.ferre@...el.com,
	linux-kernel@...r.kernel.org, robh+dt@...nel.org,
	broonie@...nel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: at91-sama5d3_xplained: add the regulator
 device node

On 21/04/2014 at 11:54:43 +0200, Alexandre Belloni wrote :
> Hi,
> 
> On 21/04/2014 at 12:29:07 +0800, Wenyou Yang wrote :
> > +
> > +						vddana_reg: LDO_REG2 {
> > +							regulator-name = "VDDANA";
> > +							regulator-min-microvolt = <3300000>;
> > +							regulator-max-microvolt = <3300000>;
> > +							regulator-always-on;
> 
> I'm pretty sure that one is not always on as you actually have to
> configure it to get any voltage. Are you sure you want to set the
> regulator-always-on property here ?
> 

Just to clarify my though, wouldn't it be better to make the ADC driver
handle that regulator instead of using regulator-always-on ?

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/