linux-kernel - Re: [PATCH v2 RESEND 3/4] tsi721: Use pci_enable_msix_exact() instead of pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140421132841.GA25116@dhcp-26-169.brq.redhat.com>
Date:	Mon, 21 Apr 2014 14:28:41 +0100
From:	Alexander Gordeev <agordeev@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Matt Porter <mporter@...nel.crashing.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"Bounine, Alexandre" <Alexandre.Bounine@....com>
Subject: Re: [PATCH v2 RESEND 3/4] tsi721: Use pci_enable_msix_exact()
 instead of pci_enable_msix()

On Fri, Mar 07, 2014 at 01:35:34PM +0000, Bounine, Alexandre wrote:
> > From: Alexander Gordeev [mailto:agordeev@...hat.com]
> > Sent: Thursday, March 06, 2014 3:11 PM
> > To: linux-kernel@...r.kernel.org
> > Cc: Alexander Gordeev; Matt Porter; Bounine, Alexandre; linux-
> > pci@...r.kernel.org
> > Subject: [PATCH v2 RESEND 3/4] tsi721: Use pci_enable_msix_exact()
> > instead of pci_enable_msix()
> > 
> > As result of deprecation of MSI-X/MSI enablement functions
> > pci_enable_msix() and pci_enable_msi_block() all drivers
> > using these two interfaces need to be updated to use the
> > new pci_enable_msi_range()  or pci_enable_msi_exact()
> > and pci_enable_msix_range() or pci_enable_msix_exact()
> > interfaces.
> 
> 
> Acked-by: Alexandre Bounine <alexandre.bounine@....com>
> 
> Andrew, please pick up this patch for the -next tree.

Hi Andrew,

Could you please pick up this patch?

Thanks!

> > Signed-off-by: Alexander Gordeev <agordeev@...hat.com>
> > Cc: Matt Porter <mporter@...nel.crashing.org>
> > Cc: Alexandre Bounine <alexandre.bounine@....com>
> > Cc: linux-pci@...r.kernel.org
> > ---
> >  drivers/rapidio/devices/tsi721.c |   11 +++--------
> >  1 files changed, 3 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/rapidio/devices/tsi721.c
> > b/drivers/rapidio/devices/tsi721.c
> > index ff7cbf2..ce08e8d 100644
> > --- a/drivers/rapidio/devices/tsi721.c
> > +++ b/drivers/rapidio/devices/tsi721.c
> > @@ -768,15 +768,10 @@ static int tsi721_enable_msix(struct
> > tsi721_device *priv)
> >  	}
> >  #endif /* CONFIG_RAPIDIO_DMA_ENGINE */
> > 
> > -	err = pci_enable_msix(priv->pdev, entries, ARRAY_SIZE(entries));
> > +	err = pci_enable_msix_exact(priv->pdev, entries,
> > ARRAY_SIZE(entries));
> >  	if (err) {
> > -		if (err > 0)
> > -			dev_info(&priv->pdev->dev,
> > -				 "Only %d MSI-X vectors available, "
> > -				 "not using MSI-X\n", err);
> > -		else
> > -			dev_err(&priv->pdev->dev,
> > -				"Failed to enable MSI-X (err=%d)\n", err);
> > +		dev_err(&priv->pdev->dev,
> > +			"Failed to enable MSI-X (err=%d)\n", err);
> >  		return err;
> >  	}
> > 
> > --
> > 1.7.7.6
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/