linux-kernel - Re: [PATCH] mm/swap: cleanup *lru_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHz2CGWVo9ZXDY7S5_OU-6C1syiMuXX4qCpMUM+YCMkDUcSSZg@mail.gmail.com>
Date:	Mon, 21 Apr 2014 12:02:42 +0800
From:	Jianyu Zhan <nasa4836@...il.com>
To:	Zhang Yanfei <zhangyanfei@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Minchan Kim <minchan@...nel.org>,
	Johannes Weiner <hannes@...xchg.org>, shli@...nel.org,
	bob.liu@...cle.com, sjenning@...ux.vnet.ibm.com,
	iamjoonsoo.kim@....com, aquini@...hat.com,
	Mel Gorman <mgorman@...e.de>, Rik van Riel <riel@...hat.com>,
	Andrea Arcangeli <aarcange@...hat.com>, khalid.aziz@...cle.com,
	LKML <linux-kernel@...r.kernel.org>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>
Subject: Re: [PATCH] mm/swap: cleanup *lru_cache_add* functions

Hi,  Yanfei,

On Mon, Apr 21, 2014 at 9:00 AM, Zhang Yanfei
<zhangyanfei@...fujitsu.com> wrote:
> What should be exported?
>
> lru_cache_add()
> lru_cache_add_anon()
> lru_cache_add_file()
>
> It seems you only export lru_cache_add_file() in the patch.

Right, lru_cache_add_anon() is only used by VM code, so it should not
be exported.

lru_cache_add_file() and lru_cache_add() are supposed to be used by
vfs ans fs code.

But  now only lru_cache_add_file() is  used by CIFS and FUSE, which
both could be
built as module, so it must be exported;  and lru_cache_add() has now
no module users,
so as Rik suggests, it is unexported too.


Thanks,
Jianyu Zhan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/