linux-kernel - Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140421165050.GB8874@tassilo.jf.intel.com>
Date:	Mon, 21 Apr 2014 09:50:50 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	Andi Kleen <andi@...stfloor.org>, mmarek@...e.cz,
	"H. Peter Anvin" <hpa@...or.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Kbuild, lto: Avoid reported warning with strtoul

On Mon, Apr 21, 2014 at 10:25:18AM +0530, Viresh Kumar wrote:
> > --- a/scripts/mod/modpost.c
> > +++ b/scripts/mod/modpost.c
> > @@ -1707,7 +1707,7 @@ static char *remove_dot(char *s)
> >         int n = strcspn(s, ".");
> >
> >         if (n > 0 && s[n] != 0) {
> > -               strtoul(s + n + 1, &end, 10);
> > +               (void)strtoul(s + n + 1, &end, 10);
> 
> I tried this earlier before reporting and it still had the same problem :(
> I tried it again just to cross check and still getting this:
> 
> scripts/mod/modpost.c: In function ‘remove_dot’:
> scripts/mod/modpost.c:1710:3: warning: ignoring return value of
> ‘strtoul’, declared with attribute warn_unused_result
> [-Wunused-result]

Hmm that's odd. I guess could assign it to a dummy variable or use
viro's variant.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/