linux-kernel - Re: [PATCH] usb: phy: msm: Select secondary PHY via TCSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 21 Apr 2014 12:08:40 -0500
From:	Felipe Balbi <balbi@...com>
To:	Tim Bird <tbird20d@...il.com>
CC:	<balbi@...com>, "Ivan T. Ivanov" <iivanov@...sol.com>,
	<linux-arm-msm@...r.kernel.org>, Kumar Gala <galak@...eaurora.org>,
	David Brown <davidb@...eaurora.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	<linux-usb@...r.kernel.org>, Tim Bird <tim.bird@...ymobile.com>
Subject: Re: [PATCH] usb: phy: msm: Select secondary PHY via TCSR

On Mon, Apr 21, 2014 at 10:03:28AM -0700, Tim Bird wrote:
> On Mon, Apr 21, 2014 at 9:14 AM, Felipe Balbi <balbi@...com> wrote:
> > Hi,
> >
> > On Fri, Apr 04, 2014 at 03:18:11PM -0700, Tim Bird wrote:
> >> Select the secondary PHY using the TCSR register, if phy-num=1
> >> in the DTS (or phy_number is set in the platform data).  The
> >> SOC has 2 PHYs which can be used with the OTG port, and this
> >> code allows configuring the correct one.
> >>
> >> Note: This resolves the problem I was seeing where I couldn't
> >> get the USB driver working at all on a dragonboard, from cold
> >> boot.  This patch depends on patch 5/14 from Ivan's msm USB
> >> patch set.  It does not use DT for the register address, as
> >> there's no evidence that this address changes between SoC
> >> versions.
> >>
> >> Signed-off-by: Tim Bird <tim.bird@...ymobile.com>
> >
> > doesn't apply:
> >
> > checking file drivers/usb/phy/phy-msm-usb.c
> > Hunk #1 succeeded at 1412 with fuzz 2 (offset -106 lines).
> > Hunk #2 FAILED at 1581.
> > 1 out of 2 hunks FAILED
> > checking file include/linux/usb/msm_hsusb_hw.h
> 
> Sorry about that.
> 
> Did you apply this on top of Ivan's USB patch set?  That's a pre-requisite.

hehe, probably not :-)

> I've communicated privately with Ivan, and he's preparing an updated
> patch set which incorporates this fix and a few other things. This should
> be showing up soon-ish.

alright, thanks

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)