linux-kernel - Re: [PATCH 16/28] nios2: System calls handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 21 Apr 2014 22:46:34 +0200
From:	Pavel Machek <pavel@...x.de>
To:	Ley Foon Tan <lftan@...era.com>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, cltang@...esourcery.com,
	mtk.manpages@...il.com
Subject: Re: [PATCH 16/28] nios2: System calls handling

Hi!

> > Also... explanation why you need this syscall while other
> > architectures live happily without it would be nice.
> This syscall exist in nios2 port since old days and some users already
> used it for sometimes.
> Like mentioned by Greet, 12 our of 28 architectures provide such a syscall.

Would it make sense to create common code for this syscall?

> >> +/* sys_cacheflush -- flush the processor cache. */
> >> +asmlinkage int sys_cacheflush(unsigned long addr, unsigned long len,
> >> +                             unsigned int op)
> >> +{
> >> +     struct vm_area_struct *vma;
> >> +
> >> +     if (len == 0)
> >> +             return 0;
> >
> > op is being ignored? You should remove it... or if (op) return -EINVAL
> > if you want future extensions.
> Yes, op argument is being ignored. Okay, will add the return -EINVAL
> if op is non-zero.

Thanks!
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/