linux-kernel - Re: [PATCH v7] fs: FAT: Add support for DOS 1.x formatted volumes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sip7dtxu.fsf@devron.myhome.or.jp>
Date:	Mon, 21 Apr 2014 16:26:37 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Conrad Meyer <cse.cem@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7] fs: FAT: Add support for DOS 1.x formatted volumes

Conrad Meyer <cse.cem@...il.com> writes:

> +/*
> + * A deserialized copy of the on-disk structure laid out in struct
> + * fat_boot_sector.
> + */
> +struct fat_bios_param_block {
> +	u16	fat_sector_size;
> +	u8	fat_sec_per_clus;
> +	u16	fat_reserved;
> +	u8	fat_fats;
> +	u16	fat_dir_entries;
> +	u16	fat_sectors;
> +	u16	fat_fat_length;
> +	u32	fat_total_sect;
> +
> +	u8	fat16_state;
> +	u32	fat16_vol_id;
> +
> +	u32	fat32_length;
> +	u32	fat32_root_cluster;
> +	u16	fat32_info_sector;
> +	u8	fat32_state;
> +	u32	fat32_vol_id;
> +
> +};

Looks good. But nobody use this structure except fat_fill_inode(). So,
please move this into inode.c.

With above last change,

Acked-by: OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/