linux-kernel - Re: [PATCH V2 01/19] tick: trivial cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Apr 2014 23:23:33 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Viresh Kumar <viresh.kumar@...aro.org>
Cc:	tglx@...utronix.de, linaro-kernel@...ts.linaro.org,
	linaro-networking@...aro.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 01/19] tick: trivial cleanups

On Mon, Apr 21, 2014 at 03:24:57PM +0530, Viresh Kumar wrote:
> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c
> index 6558b7a..9e9ddba 100644
> --- a/kernel/time/tick-sched.c
> +++ b/kernel/time/tick-sched.c
> @@ -108,7 +108,6 @@ static ktime_t tick_init_jiffy_update(void)
>  	return period;
>  }
>  
> -
>  static void tick_sched_do_timer(ktime_t now)
>  {
>  	int cpu = smp_processor_id();
> @@ -248,8 +247,8 @@ void tick_nohz_full_kick_all(void)
>  		return;
>  
>  	preempt_disable();
> -	smp_call_function_many(tick_nohz_full_mask,
> -			       nohz_full_kick_ipi, NULL, false);
> +	smp_call_function_many(tick_nohz_full_mask, nohz_full_kick_ipi, NULL,
> +			       false);

Breaking < 80 char lines is arguable although I'm not sure it still matters in 2014.

But I don't see much the point of the above change. I usually prefer when line contents
are a bit balanced. It may be a matter of taste I guess.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/