linux-kernel - Re: [PATCH] modpost: Fix ressource leak in read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sip5hlji.fsf@rustcorp.com.au>
Date:	Tue, 22 Apr 2014 16:56:41 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Michal Marek <mmarek@...e.cz>, Andi Kleen <ak@...ux.intel.com>,
	Christian Engelmayer <cengelma@....at>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] modpost: Fix ressource leak in read_dump()

Michal Marek <mmarek@...e.cz> writes:

> On 2014-04-06 02:05, Andi Kleen wrote:
>> On Sun, Apr 06, 2014 at 12:36:49AM +0200, Christian Engelmayer wrote:
>>> Function read_dump() memory maps the input via grab_file(), but fails to call
>>> the corresponding unmap function. Add the missing call to release_file().
>>> Detected by Coverity: CID 1192419
>> 
>> It doesn't matter at all. All memory is freed on exit() in this program.
>
> The leak can disturb in valgrind output.

Yeah.  If release_file() didn't exist at all, I'd agree with Andi.  As
it is, I've queued the patch (with typo in title fixed).

Thanks!
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/