linux-kernel - Re: [PATCH] radio-bcm2048.c: fix wrong overflow check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201404221055.54799@pali>
Date:	Tue, 22 Apr 2014 10:55:53 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Pavel Machek <pavel@....cz>, hans.verkuil@...co.com,
	m.chehab@...sung.com, ext-eero.nurkkala@...ia.com,
	nils.faerber@...nelconcepts.de, joni.lapilainen@...il.com,
	freemangordon@....bg, sre@...g0.de, Greg KH <greg@...ah.com>,
	trivial@...nel.org, kernel list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] radio-bcm2048.c: fix wrong overflow check

On Tuesday 22 April 2014 10:39:17 Dan Carpenter wrote:
> On Sun, Apr 20, 2014 at 04:56:22PM +0200, Pavel Machek wrote:
> > Fix wrong overflow check in radio-bcm2048.
> > 
> > Signed-off-by: Pali Rohár <pali.rohar@...il.com>
> > Signed-off-by: Pavel Machek <pavel@....cz>
> 
> Signed off means like you're signing a legal document to show
> that you didn't do anything illegal when you handled the
> patch.  Was this patch authored by Pali?  If so, then use the
> From: header.
> 
> Btw, I reported this bug on Dec 10 last year.  It's better
> that we fix it now than not fix it at all but we could have
> done better.  Was the kbuild-zero-day bug report format
> confusing or how could I have helped out there?
> 
> regards,
> dan carpenter

Hello, I sent this patch months ago, but not generated by 
commmand git format-patch. And yes, this problem was reported by 
some public static code checker.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)