linux-kernel - Re: [PATCH v2 1/2] Staging: dgnc: dgnc_driver: fixed dgnc_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140422092754.GA26890@mwanda>
Date:	Tue, 22 Apr 2014 12:27:54 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	"Son P. Nguyen" <fastmutex@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] Staging: dgnc: dgnc_driver: fixed dgnc_pci_tbl
 definition

I like the idea of this patch but the v2 version still doesn't compile.
I don't understand how you can write such a nice patch and not even test
that it compiles.  Twice.  That's not ok.

On Sun, Apr 20, 2014 at 06:05:38PM +0000, Son P. Nguyen wrote:
> From: "Son P. Nguyen" <fastmutex@...il.com>

Don't include this when you are sending your own patch.

> 
> Fixed dgnc_pci_tbl definition for correct coding style

This description is not enough.

> 
> PS: This is for task 10 of eudyptula-challenge.

Don't include this line.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/