[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140422110236.GC17116@hmsreliant.think-freely.org>
Date: Tue, 22 Apr 2014 07:02:36 -0400
From: Neil Horman <nhorman@...driver.com>
To: Jianyu Zhan <nasa4836@...il.com>
Cc: davem@...emloft.net, lizefan@...wei.com, tj@...nel.org,
aris@...hat.com, dborkman@...hat.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netclassid_cgroup: explicitly init the early_init field
On Tue, Apr 22, 2014 at 01:31:16PM +0800, Jianyu Zhan wrote:
> For a cgroup subsystem who should init early, then it should carefully
> take care of the implementation of css_alloc, because it will be called
> before mm_init() setup the world.
>
> Luckily we don't, and we better explicitly assign the early_init field
> to 0, for document reason.
>
> Signed-off-by: Jianyu Zhan <nasa4836@...il.com>
> ---
> net/core/netclassid_cgroup.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/core/netclassid_cgroup.c b/net/core/netclassid_cgroup.c
> index 22931e1..1b07dca 100644
> --- a/net/core/netclassid_cgroup.c
> +++ b/net/core/netclassid_cgroup.c
> @@ -108,4 +108,5 @@ struct cgroup_subsys net_cls_cgrp_subsys = {
> .css_free = cgrp_css_free,
> .attach = cgrp_attach,
> .base_cftypes = ss_files,
> + .early_init = 0,
> };
> --
> 2.0.0-rc0
>
>
Agreed, this doesn't make sense, early_init is default assigned to zero. What
problem are you trying to solve?
Neil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists