linux-kernel - Re: [PATCH] netprio_cgroup: explicitly init the early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140422111906.GD17116@hmsreliant.think-freely.org>
Date:	Tue, 22 Apr 2014 07:19:06 -0400
From:	Neil Horman <nhorman@...driver.com>
To:	Jianyu Zhan <nasa4836@...il.com>
Cc:	davem@...emloft.net, lizefan@...wei.com, tj@...nel.org,
	daniel.wagner@...-carit.de, gaofeng@...fujitsu.com,
	stephen@...workplumber.org, jiri@...nulli.us,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] netprio_cgroup: explicitly init the early_init field

On Tue, Apr 22, 2014 at 01:32:02PM +0800, Jianyu Zhan wrote:
> For a cgroup subsystem who should init early, then it should carefully
> take care of the implementation of css_alloc, because it will be called
> before mm_init() setup the world.
> 
> Luckily we don't, and we better explicitly assign the early_init field
> to 0, for document reason.
> 
> Signed-off-by: Jianyu Zhan <nasa4836@...il.com>
> ---
>  net/core/netprio_cgroup.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/core/netprio_cgroup.c b/net/core/netprio_cgroup.c
> index 13ddd68..fc21035 100644
> --- a/net/core/netprio_cgroup.c
> +++ b/net/core/netprio_cgroup.c
> @@ -250,6 +250,7 @@ struct cgroup_subsys net_prio_cgrp_subsys = {
>  	.css_free	= cgrp_css_free,
>  	.attach		= net_prio_attach,
>  	.base_cftypes	= ss_files,
> +	.early_init	= 0,
>  };
>  
>  static int netprio_device_event(struct notifier_block *unused,
> -- 
> 2.0.0-rc0
> 
> 
NACK, for the same reason that it doesn't make sense for net_classid.
Early_init should already be zero.  What problem are you trying to solve here?

Neil

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/