linux-kernel - Re: [Resend Patch 8/9] I2C/ACPI: Move ACPI related code to i2c-acpi.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140422113827.GL30677@intel.com>
Date:	Tue, 22 Apr 2014 14:38:27 +0300
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Lan Tianyu <tianyu.lan@...el.com>
Cc:	wsa@...-dreams.de, rjw@...ysocki.net, awilliam@...hat.com,
	lenb@...nel.org, linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: Re: [Resend Patch 8/9] I2C/ACPI: Move ACPI related code to i2c-acpi.c

On Tue, Apr 22, 2014 at 02:24:14PM +0800, Lan Tianyu wrote:
> diff --git a/include/linux/i2c.h b/include/linux/i2c.h
> index 681e689..fc1ef42 100644
> --- a/include/linux/i2c.h
> +++ b/include/linux/i2c.h
> @@ -586,7 +586,10 @@ static inline struct i2c_adapter *of_find_i2c_adapter_by_node(struct device_node
>  #ifdef CONFIG_ACPI
>  int acpi_i2c_install_space_handler(struct i2c_adapter *adapter);
>  void acpi_i2c_remove_space_handler(struct i2c_adapter *adapter);
> +void acpi_i2c_register_devices(struct i2c_adapter *adap);
>  #else
> +static inline void acpi_i2c_register_devices(struct i2c_adapter *adap) {};

Semicolon is not needed here.

Apart from that,

Reviewed-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/