linux-kernel - Re: [PATCH 20/28] nios2: Time keeping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201404221544.33399.arnd@arndb.de>
Date:	Tue, 22 Apr 2014 15:44:33 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Ley Foon Tan <lftan@...era.com>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, lftan.linux@...il.com,
	cltang@...esourcery.com
Subject: Re: [PATCH 20/28] nios2: Time keeping

On Friday 18 April 2014, Ley Foon Tan wrote:
> +static inline unsigned long read_timersnapshot(void)
> +{
> +       unsigned long count;
> +
> +       outw(0, timer_membase + ALTERA_TIMER_SNAPL_REG);
> +       count =
> +               inw(timer_membase + ALTERA_TIMER_SNAPH_REG) << 16 |
> +               inw(timer_membase + ALTERA_TIMER_SNAPL_REG);
> +
> +       return count;
> +}
> +
> +static inline void write_timerperiod(unsigned long period)
> +{
> +       outw(period, timer_membase + ALTERA_TIMER_PERIODL_REG);
> +       outw(period >> 16, timer_membase + ALTERA_TIMER_PERIODH_REG);
> +}

It's wrong to use 'outw' if this device is not on an PC-style ISA bus,
which I assume it is not. Since timer_membase is an __iomem pointer,
I'm sure you want to use writew() instead.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/