[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20140422142443.GB15745@arch.cereza>
Date: Tue, 22 Apr 2014 11:24:43 -0300
From: Ezequiel Garcia <ezequiel.garcia@...e-electrons.com>
To: Ley Foon Tan <lftan@...era.com>
Cc: linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-doc@...r.kernel.org, lftan.linux@...il.com,
cltang@...esourcery.com
Subject: Re: [PATCH 06/28] nios2: Memory management
Hi Ley Foon,
On Apr 18, Ley Foon Tan wrote:
> +/*
> + * PAGE_SHIFT determines the page size
> + */
> +#define PAGE_SHIFT 12
> +#define PAGE_SIZE 4096
> +#define PAGE_MASK (~(PAGE_SIZE - 1))
> +
How about something like this:
/* PAGE_SHIFT determines the page size */
#define PAGE_SHIFT 12
#define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK (~((1 << PAGE_SHIFT) - 1))
Otherwise, the PAGE_SIZE macro above produces some warnings, IIRC.
--
Ezequiel GarcĂa, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists