linux-kernel - Re: [PATCH 03/10] staging: rtl8188eu: Remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 22 Apr 2014 09:28:00 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Dan Carpenter <dan.carpenter@...cle.com>,
	navin patidar <navin.patidar@...il.com>
CC:	devel@...verdev.osuosl.org, Greg KH <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 03/10] staging: rtl8188eu: Remove _ReadLEDSetting() function.

On 04/22/2014 09:14 AM, Dan Carpenter wrote:
> On Tue, Apr 22, 2014 at 07:31:50PM +0530, navin patidar wrote:
>> Hi dan
>>
>> it's just a cleanup patch and i also tested all patches of this patch
>> series on the hardware (TP-LINK  TL-WN723N).
>> my mistake i should have added "Tested-by" tag for all patches.
>>
>> Tested-by: navin patidar <navin.patidar@...il.com>
>
> No no.  It's not necesary to add a tested by to everything.  It was just
> something I was curious about.  The patches looked ok.  If you hadn't
> tested them I would review them a second time more carefully.

To me, the opposite case is true. If you have not tested, then you need to 
explicitly state "compile tested only" in the commit message. Without saying 
that, your signed-off-by is implying that you have tested, as well as declaring 
that you own the copyright to the material.

Larry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/