linux-kernel - Re: [PATCH] locks: rename file-private locks to "open file description locks"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5356808B.3040303@gmail.com>
Date:	Tue, 22 Apr 2014 17:45:31 +0300
From:	Boaz Harrosh <openosd@...il.com>
To:	Jeff Layton <jlayton@...hat.com>, linux-fsdevel@...r.kernel.org
CC:	linux-kernel@...r.kernel.org, samba-technical@...ts.samba.org,
	Ganesha NFS List <nfs-ganesha-devel@...ts.sourceforge.net>,
	libc-alpha <libc-alpha@...rceware.org>,
	Michael Kerrisk <mtk.manpages@...il.com>,
	Christoph Hellwig <hch@...radead.org>,
	Carlos O'Donell <carlos@...hat.com>,
	Stefan Metzmacher <metze@...ba.org>,
	Andy Lutomirski <luto@...capital.net>,
	Frank Filz <ffilzlnx@...dspring.com>,
	Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH] locks: rename file-private locks to "open file description
 locks"

On 04/22/2014 03:23 PM, Jeff Layton wrote:
<>
> 
> We're going to have to live with these for a long time, so it's
> important that we be happy with the names before we're stuck with them.
> The consensus on the lists so far is that they should be rechristened as
> "open file description locks".
> 

I completely agree with the rename. (Though could you please post
the rest of the rename patches for review)

Just a very small nit. My native language is not English but I would
rather you use "file-descriptor" (with an '-' as well) and not
use "description" in the English name of the lock. This is
because stated like that, "description" might refer to the
locks and not to the file in the sentence. file-descriptor is
more clear I think. (For me it was confusing at first before I realized
what you meant)

Just my $0.017
Thanks

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/