linux-kernel - Re: [PATCH 2/9] perf hists: Introduce hists__add_nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140422145203.GH1104@krava.brq.redhat.com>
Date:	Tue, 22 Apr 2014 16:52:03 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...nel.org>,
	Paul Mackerras <paulus@...ba.org>,
	Namhyung Kim <namhyung.kim@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH 2/9] perf hists: Introduce hists__add_nr_events()

On Tue, Apr 22, 2014 at 05:49:44PM +0900, Namhyung Kim wrote:
> The hists__add_nr_events() is a helper function intended to be ran
> inside of hists__inc_nr_entries().  However this requires other
> changes that handled in the next patch.
> 
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/util/hist.c | 32 +++++++++++++++++++++-----------
>  1 file changed, 21 insertions(+), 11 deletions(-)
> 
> diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c
> index 5a892477aa50..1c77714f668d 100644
> --- a/tools/perf/util/hist.c
> +++ b/tools/perf/util/hist.c
> @@ -317,6 +317,27 @@ static struct hist_entry *hist_entry__new(struct hist_entry *template)
>  	return he;
>  }
>  
> +static void __events_stats__add(struct events_stats *stats, u32 type, u32 val)
> +{
> +	stats->nr_events[0] += val;
> +	stats->nr_events[type] += val;
> +}
> +
> +void events_stats__inc(struct events_stats *stats, u32 type)
> +{
> +	__events_stats__add(stats, type, 1);
> +}
> +
> +void hists__inc_nr_events(struct hists *hists, u32 type)
> +{
> +	__events_stats__add(&hists->stats, type, 1);
> +}
> +
> +static void hists__add_nr_events(struct hists *hists, u32 type, u32 val)
> +{
> +	__events_stats__add(&hists->stats, type, val);
> +}

adding static function with no usage breaks build..
we dont want that, eventhough it's fixed in the next commit

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/